feat(http): keep slashes in queryParams in redirects #4928
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows us to easily test our redirect path construction logic where we get the relative path, the query string and construct a redirect path. By extracting this from `redirect`, we can easily test this logic in a unit test. I did this so we could test some logic where slashes in query strings should be made human-friendly for users.
|
✨ Coder.com for PR #4928 deployed! It will be updated on every commit.
|
jsjoeio
force-pushed
the
jsjoeio/test-redirect
branch
from
5b78e3c to
31e131b
Compare
jsjoeio
changed the title
Codecov Report
@@ Coverage Diff @@
## main #4928 +/- ##
==========================================
+ Coverage 69.96% 70.02% +0.05%
==========================================
Files 29 29
Lines 1655 1658 +3
Branches 364 364
==========================================
+ Hits 1158 1161 +3
Misses 423 423
Partials 74 74
Continue to review full report at Codecov.
|
28 tasks
code-asher
approved these changes
Mar 1, 2022
TinLe
pushed a commit
to TinLe/code-server
that referenced
this pull request
Apr 23, 2022
* refactor(http): extract logic into constructRedirectPath This allows us to easily test our redirect path construction logic where we get the relative path, the query string and construct a redirect path. By extracting this from `redirect`, we can easily test this logic in a unit test. I did this so we could test some logic where slashes in query strings should be made human-friendly for users. * feat(testing): add tests for constructRedirectPath Co-authored-by: Asher <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a user opens code-server at a url like
localhost:8080without the-e(ignore last opened flag), we redirect to that workspace and append the folder as a query param.Before, it would encode the url to something like:
localhost:8080/?folder=%2FUsers%2Fjp%2Fdev%2FcoderNow, it maintains the slashes and redirects to:
localhost:8080/?folder=/Users/p/Fdev/coderFixes this issue coder/vscode#45 (comment) identified in the VS Code 1.64 update.